[SPARK-4952][Core]Handle ConcurrentModificationExceptions in SparkEnv.environmentDetails #3788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #24778 has started for PR 3788 at commit
|
| @@ -395,7 +395,7 @@ object SparkEnv extends Logging { | |||
| val sparkProperties = (conf.getAll ++ schedulerMode).sorted | |||
|
|
|||
| // System properties that are not java classpaths | |||
| val systemProperties = System.getProperties.iterator.toSeq | |||
| val systemProperties = Utils.getSystemProperties.toSeq | |||
There was a problem hiding this comment.
It wasn't clear to me at first whether this is the culprit, but it looks so since the underlying object being modified is a java.util.Properties. The defensive copy made in Utils should be thread-safe in the sense that Hashtable.clone() is synchronized. LGTM.
|
Test build #24778 has finished for PR 3788 at commit
|
|
Test PASSed. |
|
Thanks for this patch and @srowen for the review! I'll pull this in. |
asfgit
pushed a commit
that referenced
this pull request
Dec 27, 2014
….environmentDetails Author: GuoQiang Li <witgo@qq.com> Closes #3788 from witgo/SPARK-4952 and squashes the following commits: d903529 [GuoQiang Li] Handle ConcurrentModificationExceptions in SparkEnv.environmentDetails (cherry picked from commit 080ceb7) Signed-off-by: Patrick Wendell <pwendell@gmail.com>
asfgit
pushed a commit
that referenced
this pull request
Dec 27, 2014
….environmentDetails Author: GuoQiang Li <witgo@qq.com> Closes #3788 from witgo/SPARK-4952 and squashes the following commits: d903529 [GuoQiang Li] Handle ConcurrentModificationExceptions in SparkEnv.environmentDetails (cherry picked from commit 080ceb7) Signed-off-by: Patrick Wendell <pwendell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.